Code quality
Test Suite Cleanup: Delete Brittle Tests Without Losing Confidence
Test suite cleanup is confidence design. Brittle tests waste time when they fail for timing, mocks, snapshots, or fixtures that no longer represent production, but deleting them blindly can remove the last check around a critical behavior.
The useful output is a test cleanup pull request with failure evidence, protected behavior, replacement coverage, removed fixtures, and CI result. Keep the review concrete: Rewrite or narrow tests that protect real behavior before deleting duplicates, then make the next action visible to the team that owns the risk. That matters because the cleanup can still go wrong when removing tests that still cover critical behavior.
Key takeaways
- Treat each cleanup candidate as an owned system with dependencies, not anonymous clutter.
- Use several CI cycles plus one release window for behavior covered by the candidate tests before deciding that “quiet” means “unused.”
- Prefer reversible changes first when removing tests that still cover critical behavior is still plausible.
- Leave behind a test cleanup pull request with failure evidence, protected behavior, replacement coverage, removed fixtures, and CI result so the next review starts with context.
- Measure the result as lower spend, lower risk, less operational drag, or clearer ownership.
Find Confidence Gaps
Start with one test package, CI job, or behavior area where failure history, production risk, coverage, fixtures, and owners can be reviewed together. The best cleanup scope is small enough that owners can answer quickly but wide enough to include the attachments that make removal risky.
| Field | Why it matters |
|---|---|
| Owner | Cleanup needs a person or team that can accept the decision |
| Current purpose | A short reason to keep the item, written in present tense |
| Last meaningful use | owners, callers, last change, runtime behavior, and deletion confidence |
| Dependency evidence | repository search, tests, logs, deploy history, and owner review |
| Risk if wrong | The outage, data loss, access failure, or rollback gap the review must avoid |
| Next action | Keep, reduce, archive, disable, remove, or investigate |
Do not make the inventory larger than the decision. A short list with owners and evidence beats a perfect spreadsheet that nobody is willing to act on.
Test Evidence to Review
The useful question is not “how old is it?” It is “what would break, become harder to recover, or lose accountability if this disappeared?” For test suite cleanup, collect enough evidence to answer that without relying on naming conventions.
| Check | What to look for | Cleanup signal |
|---|---|---|
| Failure pattern | Recent flakes, retries, quarantine notes, timeout history, and failure reasons | The test fails for harness behavior instead of product risk |
| Behavior value | Requirement, incident, bug report, contract, or user path the test protects | No current behavior owner can explain why the test matters |
| Coverage replacement | Unit, integration, contract, e2e, or observability signal that covers the same risk | A clearer check already protects the behavior |
| Fixture and mock drift | Snapshots, fake data, stubbed services, dates, and assumptions | The setup no longer matches supported production behavior |
Use several signals together. Activity can miss monthly jobs and incident-only paths. Ownership can be stale. Cost can distract from security or recovery risk. The strongest case combines runtime data, dependency checks, owner review, and a rollback plan.
If the evidence conflicts, label the item “investigate” with a named owner and review date. That is still progress because the next review starts with a narrower question.
Example Evidence Check
Review failure history and protected behavior before deleting a brittle test.
rg "${TEST_NAME}|${BEHAVIOR_NAME}" tests src docs
rg "flake|retry|quarantine|skip|todo" tests .github docs
git log --oneline -- tests/${TEST_FILE}Treat the output as a candidate list. Do not pipe these checks into delete commands; add owner review, dependency checks, and a rollback path first.
Rewrite Before Deleting
Use the least permanent move that proves the decision. In test suite cleanup, removal is only one possible outcome; reducing size, narrowing permission, shortening retention, archiving, or disabling a trigger may produce the same benefit with less risk.
- Rewrite or narrow tests that protect real behavior before deleting duplicates.
- Delete tests in small pull requests with the CI job and risk owner visible.
- Remove obsolete fixtures, snapshots, and mocks with the tests that depended on them.
Track the cleanup candidate with a simple priority score:
| Score | Good sign | Bad sign |
|---|---|---|
| Impact | Meaningful spend, risk, toil, noise, or confusion disappears | The item is cheap and low-risk but politically distracting |
| Confidence | Owner, purpose, and dependency path are understood | The team is guessing from age or name |
| Reversibility | Restore, recreate, re-enable, or rollback path exists | Deletion would be the first real test |
| Prevention | A rule can stop recurrence | The same pattern will return next month |
Start with high-impact, high-confidence, reversible candidates. Defer confusing items only if they get an owner and a date; otherwise “defer” becomes another word for keeping waste permanently.
Tests That Protect Real Risk
Some cleanup candidates are supposed to look quiet. Do not rush these cases:
- Tests created after incidents, data-loss bugs, security regressions, or contract breaks.
- Slow end-to-end tests that are annoying because they cover real integration risk.
- Snapshot tests that are brittle but still document public UI or API compatibility.
For these cases, use a longer observation window, explicit owner approval, and a staged reduction. The point is not to avoid cleanup; it is to avoid making the first proof of dependency an outage.
Run the Test Cleanup PR
Run test suite cleanup as a decision review, not an open-ended hygiene project.
- Pick the narrow scope and export the candidate list.
- Add owner, current purpose, last-use evidence, dependency checks, and risk if wrong.
- Remove obvious false positives, then ask owners to choose keep, reduce, archive, disable, remove, or investigate.
- Apply the least permanent useful change first.
- Watch the signals that would reveal a bad decision.
- Complete the final removal only after the review window closes.
- Save a test cleanup pull request with failure evidence, protected behavior, replacement coverage, removed fixtures, and CI result.
For broader cleanup planning, use the cleanup library to pair this guide with related notes. If the cleanup has infrastructure impact, pair it with a visible owner, a rollback path, and a measurable business case. For infrastructure cleanup, the main cloud cost optimization checklist is a useful companion.
Keep Test Purpose Explicit
Prevention should change the creation path, not just the cleanup path. For test suite cleanup, the useful prevention fields are owner, reason to exist, removal trigger, and verification notes. Make those fields part of normal creation and review.
- Require new regression tests to link to the behavior or incident they protect.
- Track flaky tests with owner and resolution date instead of retrying forever.
- Prefer smaller deterministic tests over broad checks that only fail after releases are blocked.
The recurring review should be short: sort by impact, pick the unclear items, assign owners, and close the loop on anything nobody claims. If the review keeps producing the same class of candidate, fix the creation path instead of celebrating repeated cleanup.
Example Decision Record
Use a compact record so the cleanup can be reviewed later without reconstructing the whole investigation.
| Field | Example entry for this cleanup |
|---|---|
| Candidate | Brittle and obsolete tests in software projects |
| Why it looked stale | Low recent activity, unclear owner, or no current consumer after the first review |
| Evidence checked | Failure pattern, Behavior value, and owner confirmation |
| First reversible move | Rewrite or narrow tests that protect real behavior before deleting duplicates |
| Watch signal | The metric, alert, job, route, query, or owner complaint that would show the cleanup was wrong |
| Final action | Keep, reduce, archive, disable, or remove after several CI cycles plus one release window for behavior covered by the candidate tests |
| Prevention rule | Require new regression tests to link to the behavior or incident they protect |
This record is intentionally small. If the decision needs a long narrative, the candidate is probably not ready for removal yet. Keep investigating until the owner, evidence, reversible move, and prevention rule are clear.
FAQ
How often should teams do test suite cleanup?
Use several CI cycles plus one release window for behavior covered by the candidate tests for the first decision, then set a recurring cadence based on change rate. Fast-moving non-production systems may need monthly review; slower systems can be quarterly if every unclear item has an owner and a review date.
What is the safest first action?
The safest first action is usually ownership repair plus evidence collection. After that, rewrite or narrow tests that protect real behavior before deleting duplicates. That creates a visible test before permanent deletion.
What should not be removed quickly?
Do not rush anything connected to tests created after incidents, data-loss bugs, security regressions, or contract breaks. Also slow down when the cleanup affects recovery, compliance, customer-specific behavior, rare schedules, or security response.
How do you make the decision useful later?
Write the decision as a small operational record: candidate, owner, evidence, chosen action, watch signals, rollback path, final date, and prevention rule. That format helps future engineers, search engines, and AI assistants understand the cleanup without guessing.